Skip to content

Use shared draft-release action for resumable SMCP releases - #153

Merged
Kralizek merged 2 commits into
masterfrom
refactor/shared-release-resume
Oct 13, 2026
Merged

Kralizek merged 2 commits into
masterfrom
refactor/shared-release-resume

Conversation

@Kralizek

@Kralizek Kralizek commented Sep 16, 2026 •

Copy link
Copy Markdown
Owner

Summary

Use the newly patched ensure-github-release@v0.5 to create or safely reuse SMCP draft releases. Keep calculate-next-version responsible for the release identity and prerelease classification, and keep SMCP responsible for package publication and the final draft-to-published transition.

Changes

  • Replace both repository-specific release recovery scripts with ensure-github-release@v0.5 (draft: 'true').
  • Pass the prerelease and release-notes-start-tag outputs from calculate-next-version directly.
  • Validate that a reused release remains a GitHub Actions-owned draft before publishing packages, preserving SMCP's recovery safety policy.
  • Delete the redundant detection/creation scripts.
  • Preserve dry-run, published-release event support, package-version validation, and final release publishing.

Intentional distinction

ensure-github-release preserves existing release state, so SMCP explicitly refuses a non-draft or non-Actions-owned release. The shared action checks the tag and commit identity.

Validation

PR checks in progress. No release has been triggered.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

API failures in resumable-release detection must not be treated as missing releases.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Simplifies manual release recovery by delegating release identity to calculate-next-version@v0.3.

Changes:

  • Removes alternate resumed-version and target-checkout logic.
  • Uses the calculated tag throughout release publishing.
  • Detects matching workflow-owned draft releases.
File summaries
File Summary
.github/workflows/scripts/detect-resumable-release.sh Detects resumable draft releases for the calculated tag.
.github/workflows/release.yml Uses shared-action outputs for release version and publication.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/scripts/detect-resumable-release.sh Outdated
@Kralizek Kralizek changed the title Delegate release retry identity to shared action Use shared draft-release action for resumable SMCP releases Oct 13, 2026
@Kralizek
Kralizek force-pushed the refactor/shared-release-resume branch from 6ae1b09 to 1e7d702 Compare October 13, 2026 08:42
@Kralizek
Kralizek requested a lite review from Copilot October 13, 2026 08:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Reused releases must also be validated against the calculated prerelease classification.

1 open finding
1 resolved since last review

🧠 Review effort: Lite

Comment thread .github/workflows/release.yml
@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues were identified.

0 open findings

1 resolved since last review

🧠 Review effort: Lite

@Kralizek
Kralizek merged commit efc5890 into master Oct 13, 2026
3 checks passed
@Kralizek
Kralizek deleted the refactor/shared-release-resume branch October 13, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants